This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Migrate to Compose Navigation and delete fragments #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ic6789a43249d93eba333cfbaba9eea0f1f042009
Change-Id: I623bcbb75fd8d6e10bc882c961fafbc5636516e3
Change-Id: I52ad72604742bb89255980c27b5a5808e1fb43f0
Change-Id: Ia552340497a889d9bc03a88c99ebf13d98455010
Change-Id: I6fb161f6e8efb58dd8f1e435111ea30e2116f239
arriolac
force-pushed
the
chris/feat/813
branch
from
January 14, 2023 00:16
dbd283f
to
de4f587
Compare
Change-Id: Ice6a7a1f720cd242349a47054cf5f7b40285ed79
arriolac
force-pushed
the
chris/feat/824
branch
from
January 14, 2023 00:17
a5ecc6e
to
04ba51a
Compare
Change-Id: I2ff9b1cd1bea6d16d83f5b082ac7071a5a7c7e31
arriolac
force-pushed
the
chris/feat/824
branch
from
January 18, 2023 22:55
04ba51a
to
5d42237
Compare
Change-Id: I1abd27a79f8d637f1c8076ddd570f518e2020ba7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comments
app/src/main/java/com/google/samples/apps/sunflower/compose/SunflowerApp.kt
Show resolved
Hide resolved
app/src/main/java/com/google/samples/apps/sunflower/compose/SunflowerApp.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/samples/apps/sunflower/compose/home/HomeScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/samples/apps/sunflower/compose/home/HomeScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/google/samples/apps/sunflower/compose/home/HomeScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/samples/apps/sunflower/compose/home/HomeScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/samples/apps/sunflower/compose/home/HomeScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/samples/apps/sunflower/compose/plantdetail/PlantDetailView.kt
Show resolved
Hide resolved
simona-anomis
approved these changes
Feb 3, 2023
Change-Id: Ide730212a7607cce84c7c8f11977f08216cefae5
Change-Id: I6666aea6868467255d880fe84fdc658766a279ad
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #824