Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JetStream] Compose for tv beta migration #168

Merged
merged 20 commits into from
May 20, 2024

Conversation

chikoski
Copy link
Contributor

@chikoski chikoski commented May 15, 2024

This pull request migrates Compose for TV to 1.0.0-beta01 from 1.0.0-alpha10. More specifically, the following changes are applied:

  • Dependency updates
  • Removal of the experimental flag
  • Code updates due to components' name changes
  • Replacement of ImmersiveList with custom component as ImmersiveList is deprecated
  • Code cleanup
  • Code format with spotlessApply
  • Removal of tv-foundation from the dependencies and switching to core compose

The last item is the result of the updates on compose-foundation. LazyLists supports Mario scrolling now.

@chikoski chikoski requested a review from mlykotom May 15, 2024 06:22
@chikoski chikoski marked this pull request as draft May 15, 2024 07:28
@chikoski chikoski marked this pull request as ready for review May 16, 2024 03:16
@chikoski chikoski force-pushed the compose-for-tv-beta-migration branch from 7ece945 to 32a5086 Compare May 17, 2024 06:52
Copy link
Contributor

@mlykotom mlykotom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks great! Thanks! I have couple of things, otherwise LGTM.

@chikoski chikoski deleted the compose-for-tv-beta-migration branch May 21, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants