-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JetStream] Compose for tv beta migration #168
Merged
chikoski
merged 20 commits into
android:main
from
chikoski:compose-for-tv-beta-migration
May 20, 2024
Merged
[JetStream] Compose for tv beta migration #168
chikoski
merged 20 commits into
android:main
from
chikoski:compose-for-tv-beta-migration
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nter of the screen
… from the dependencies as a result of the update
chikoski
force-pushed
the
compose-for-tv-beta-migration
branch
from
May 17, 2024 06:52
7ece945
to
32a5086
Compare
mlykotom
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks great! Thanks! I have couple of things, otherwise LGTM.
JetStreamCompose/jetstream/src/main/java/com/google/jetstream/data/entities/MovieList.kt
Show resolved
Hide resolved
JetStreamCompose/jetstream/src/main/java/com/google/jetstream/presentation/common/Error.kt
Outdated
Show resolved
Hide resolved
JetStreamCompose/jetstream/src/main/java/com/google/jetstream/presentation/common/Loading.kt
Outdated
Show resolved
Hide resolved
JetStreamCompose/jetstream/src/main/java/com/google/jetstream/presentation/common/MoviesRow.kt
Show resolved
Hide resolved
JetStreamCompose/jetstream/src/main/java/com/google/jetstream/data/util/StringConstants.kt
Show resolved
Hide resolved
JetStreamCompose/jetstream/src/main/java/com/google/jetstream/tvmaterial/Shapes.kt
Outdated
Show resolved
Hide resolved
...reamCompose/jetstream/src/main/java/com/google/jetstream/presentation/utils/ModifierUtils.kt
Outdated
Show resolved
Hide resolved
...m/src/main/java/com/google/jetstream/presentation/utils/BringIntoViewIfChildrenAreFocused.kt
Show resolved
Hide resolved
…trong skipping mode is enabled.
…en the MovieDetailsScreen is displayed.
This was referenced May 20, 2024
christceder
approved these changes
May 20, 2024
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request migrates Compose for TV to 1.0.0-beta01 from 1.0.0-alpha10. More specifically, the following changes are applied:
The last item is the result of the updates on compose-foundation. LazyLists supports Mario scrolling now.