Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build issues because of duplicate attribute corner_radius #19

Closed
amankgo opened this issue Aug 9, 2021 · 7 comments · Fixed by #22 or #137
Closed

Build issues because of duplicate attribute corner_radius #19

amankgo opened this issue Aug 9, 2021 · 7 comments · Fixed by #22 or #137
Assignees
Labels
bug Something isn't working

Comments

@amankgo
Copy link

amankgo commented Aug 9, 2021

Describe the bug
Build issues because of duplicate attribute.
AAPT: error: duplicate value for resource 'attr/corner_radius' with config ''

https://github.com/mocklets/pluto/blob/445ad948e282a2054044056bf9a26c15b0820b82/pluto/src/main/res/values/attr.xml#L5

Can we append resource prefix here also to not use a common name which might conflict with some other library in big projects?

To Reproduce
Steps to reproduce the behavior:

  1. Add implementation 'com.crystal:crystalrangeseekbar:1.1.3' library (Just to replicate the conflict)
  2. Build.

Expected behavior
There should be no AAPT error and project should build without any issue.

Build Environment:

  • Library Version : All versions
@amankgo amankgo added the bug Something isn't working label Aug 9, 2021
srtvprateek added a commit that referenced this issue Aug 11, 2021
- removed redundant attribute
mocklets-tech pushed a commit that referenced this issue Aug 11, 2021
- removed redundant attribute
@srtvprateek srtvprateek pinned this issue Aug 11, 2021
@srtvprateek srtvprateek unpinned this issue Aug 11, 2021
@srtvprateek
Copy link
Member

fixed, PR: #22

@srtvprateek srtvprateek linked a pull request Aug 11, 2021 that will close this issue
@amankgo
Copy link
Author

amankgo commented Aug 11, 2021

Thank you for quick fix. Can you tell when are you planning for next release.
Also I am happy to contribute to this project if you like.

@srtvprateek
Copy link
Member

working on 1 issue currently, will be releasing new version soon.

@srtvprateek
Copy link
Member

i would love to see you contributing 💯
currently, our contribution guidelines are WIP, will publish those soon.

@srtvprateek
Copy link
Member

library version v1.0.4 is live with the fix

AlexanderShirokih pushed a commit to rncb-dev/pluto that referenced this issue Sep 24, 2021
- removed redundant attribute
@saranakkaraviwat
Copy link

@srtvprateek i found this issue again in 2.0.1-beta

srtvprateek added a commit that referenced this issue Apr 29, 2022
srtvprateek added a commit that referenced this issue Apr 29, 2022
@srtvprateek
Copy link
Member

@saranakkaraviwat thanks for raising this,
this is fixed in #137, will be available in the next version.

@srtvprateek srtvprateek linked a pull request Apr 29, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants