-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dataStore_pref): show all the pref data and a sample #117
Merged
srtvprateek
merged 19 commits into
androidPluto:develop
from
rishabhsinghbisht:feat_datastore_pref_support
Apr 6, 2022
Merged
feat(dataStore_pref): show all the pref data and a sample #117
srtvprateek
merged 19 commits into
androidPluto:develop
from
rishabhsinghbisht:feat_datastore_pref_support
Apr 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rishabhsinghbisht
commented
Mar 27, 2022
•
edited by srtvprateek
Loading
edited by srtvprateek
- show data from data store preferences.
- allow to edit data.
- add noop
- add type checks if able to detect types.
- allow to add/remove key value pair.
rishabhsinghbisht
force-pushed
the
feat_datastore_pref_support
branch
from
March 29, 2022 08:33
f83b279
to
2453f6f
Compare
srtvprateek
reviewed
Apr 2, 2022
srtvprateek
reviewed
Apr 2, 2022
...store-pref-plugin-no-op/src/main/java/com/pluto/plugin/datastore/pref/DataStorePrefPlugin.kt
Outdated
Show resolved
Hide resolved
srtvprateek
requested changes
Apr 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
This reverts commit 35c5613
rishabhsinghbisht
force-pushed
the
feat_datastore_pref_support
branch
from
April 6, 2022 12:37
22d3581
to
2c5bfec
Compare
srtvprateek
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.