Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normal oriented #8

Closed
Shell64 opened this issue May 11, 2017 · 2 comments
Closed

Normal oriented #8

Shell64 opened this issue May 11, 2017 · 2 comments
Assignees

Comments

@Shell64
Copy link

Shell64 commented May 11, 2017

This is not an issue but a request.

Could you make lightmapping normal oriented? Like, make camera rotation be normal aware, it would reproduce similar results as blender I think:

http://i.imgur.com/F5KYC7z.png

The way it is atm is bad for smooth shading.

@ands
Copy link
Owner

ands commented May 11, 2017

Hi Shell64,

rotating the camera according to the interpolated normal of a triangle would result in camera frusta near clip planes intersecting with the geometry much more often, which could cause issues.
I'd rather suggest to weight the texels according to the direction of the interpolated surface normal while keeping the camera rotation as it currently is.
This would require a small API change, but yes, I can try that (or both solutions or a hybrid) at some point :).
But I can't tell you when I'll have enough time for that.

Cheers

@ands ands self-assigned this May 11, 2017
ands added a commit that referenced this issue Apr 29, 2018
Got rid of frequent gpu->cpu mem copies (consumes more gpu memory, but is faster)
@ands
Copy link
Owner

ands commented Apr 29, 2018

Hey Shell64,

not sure if you're still interested, but the normal-oriented lightmapping feature is finally in (see attached commit) :)
If you get around to try it out, please let me know how your results with it are!

Kind regards

@ands ands closed this as completed Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants