Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completions for the fish shell #147

Merged
merged 1 commit into from
Sep 30, 2015
Merged

Add completions for the fish shell #147

merged 1 commit into from
Sep 30, 2015

Conversation

languitar
Copy link
Contributor

This PR adds completions for the fish shell. Would be glad of this was merged.

@andsens
Copy link
Owner

andsens commented Sep 29, 2015

Sweeeet! Love it. Could you remove the addition to homeshick/homeshick.fish, so that the completion isn't mandatory? e.g. it could conflict with peoples own completion scripts
Instead you should add the lines on the wiki page for completion.

* completions/homeshick.fish: new completion definitions for fish
@languitar
Copy link
Contributor Author

I have updated the PR accordingly. Once it is merged, I will change the wiki.

@andsens
Copy link
Owner

andsens commented Sep 30, 2015

Looks great. Merging...

Thank you @languitar!

andsens added a commit that referenced this pull request Sep 30, 2015
Add completions for the fish shell
@andsens andsens merged commit 28e3266 into andsens:master Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants