Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fish completions on OSX #150

Merged
merged 1 commit into from
Oct 25, 2015
Merged

Fix fish completions on OSX #150

merged 1 commit into from
Oct 25, 2015

Conversation

languitar
Copy link
Contributor

Use sed instead of expr, because there is no substr in expr on OSX.

Use sed instead of expr, because there is no substr in expr on OSX.
@andsens
Copy link
Owner

andsens commented Oct 25, 2015

Doesn't echo emit a newline in fish. Wouldn't it be better to use printf?

@languitar
Copy link
Contributor Author

Well, but sed swallows everything anyway apart for the first letter.

@andsens
Copy link
Owner

andsens commented Oct 25, 2015

Ah, yeah I can see that now. OK, merging...
Thanks @languitar!

andsens added a commit that referenced this pull request Oct 25, 2015
@andsens andsens merged commit e8d021c into andsens:master Oct 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants