This repository has been archived by the owner on Jan 10, 2021. It is now read-only.
Update metadata for GNOME 3.36 #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ES6 updates for 3.32 compatibility
Gnome 3.34 compatibility
After update, the extensios stopped to load with error: ``` Archive: /tmp/L47U9Z.shell-extension.zip inflating: /home/azhidkov/.local/share/gnome-shell/extensions/audio-output-switcher@anduchs/extension.js inflating: /home/azhidkov/.local/share/gnome-shell/extensions/audio-output-switcher@anduchs/README.md inflating: /home/azhidkov/.local/share/gnome-shell/extensions/audio-output-switcher@anduchs/LICENSE creating: /home/azhidkov/.local/share/gnome-shell/extensions/audio-output-switcher@anduchs/schemas/ inflating: /home/azhidkov/.local/share/gnome-shell/extensions/audio-output-switcher@anduchs/schemas/gschemas.compiled inflating: /home/azhidkov/.local/share/gnome-shell/extensions/audio-output-switcher@anduchs/utils.js inflating: /home/azhidkov/.local/share/gnome-shell/extensions/audio-output-switcher@anduchs/schemas/org.gnome.shell.extensions.audio-output-switcher.gschema.xml extracting: /home/azhidkov/.local/share/gnome-shell/extensions/audio-output-switcher@anduchs/metadata.json JS ERROR: Extension audio-output-switcher@anduchs: TypeError: this._updateDefaultSink is not a function AudioOutputSubMenu@/home/azhidkov/.local/share/gnome-shell/extensions/audio-output-switcher@anduchs/extension.js:18:3 enable@/home/azhidkov/.local/share/gnome-shell/extensions/audio-output-switcher@anduchs/extension.js:80:23 _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:131:13 loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:263:21 callback@resource:///org/gnome/shell/ui/extensionDownloader.js:232:17 gotExtensionZipFile/<@resource:///org/gnome/shell/ui/extensionDownloader.js:99:13 ``` I'm not expert in gnome shell extensions nor js not gjs, but this fix works for me
Validate function is defined before usage
Validate function is defined before usage
Add missing `let` statement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have confirmed that the extension works in GNOME 3.36 on Fedora 32, so we can update the metadata accordingly.