Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename assertRaisesRegexp to assertRaisesRegex #101

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

migueldvb
Copy link
Contributor

This change was introduced in python 3.2

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 92.214% when pulling 6170b96 on migueldvb:tests into 695bdfe on andycasey:master.

@vsudilov
Copy link
Collaborator

This breaks the build for python27, also I'm not sure what problem this is trying to address since the last build of master succeeded on python34: https://travis-ci.org/andycasey/ads/builds/308991419

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 92.214% when pulling 1eba43f on migueldvb:tests into 695bdfe on andycasey:master.

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage remained the same at 92.659% when pulling 583413c on migueldvb:tests into 695bdfe on andycasey:master.

@migueldvb
Copy link
Contributor Author

Oh, I have replaced the assertion by the six alias that is available on python 2.7. This gets rids of DeprecationWarnings on python > 3.1.

@vsudilov
Copy link
Collaborator

LGTM thanks; want to fix the SSL errors in py27 too? ;) https://travis-ci.org/andycasey/ads/jobs/309099466

@vsudilov vsudilov merged commit fb790c2 into andycasey:master Nov 29, 2017
@migueldvb
Copy link
Contributor Author

I was looking at those travis errors. I have seem something like that before in old 2.7 releases but this is with 2.7.13... I'll take a look.

@vsudilov
Copy link
Collaborator

I strongly suspect it is this:
gabrielfalcao/HTTPretty#242

where the accepted solution is to change to a different mocking library.

No worries if you'd rather not get into that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants