Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mobile #21

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Support mobile #21

wants to merge 7 commits into from

Conversation

keicoon
Copy link

@keicoon keicoon commented Dec 27, 2020

Add Some feature for mobile

  • Add mobile.index, npm server.js , mobile-css file
  • Virtual Pad ( TODO: use canvas, not button dom )
  • Fix bug in util Serializer
  • Using https ( for Accessing save and load file )

Thanks :)

@keicoon
Copy link
Author

keicoon commented Dec 27, 2020

Test is success in safari for ios , chrome for ios :)

@andychase
Copy link
Owner

Sorry for the delay in reviewing this.

First of all huge thanks in doing this work, I'm extremely grateful for the time spent here.

I'm going to merge this to a new branch called "mobile"

Some feedback:

  • What do you think about trying to reconcile the desktop and mobile versions of the application? I personally believe in progressive enhancement so having one page that supports both mobile and desktop.
  • What's the advantage of adding an express server? Trying to keep things simple but if there's a good reason to include it then I understand

@andychase
Copy link
Owner

I merged your PR into the mobile branch

@chunibyo-wly
Copy link

Hello, thanks for your work.
if have I want to play this version, should I deploy by myself?

@andychase
Copy link
Owner

@chunibyo-wly yes right now I haven’t merged this onto the website, mostly because I would have to the express dependency for it to work with GitHub pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants