Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for the use of custom regex flags. While writing the tests, I encountered some problems monkeypatching the config neatly, so I refactored this mechanism.
The tests also uncovered that the type check in
Expression.findall()
was problematic for cross-version compatibility. This could be overcome by usingpast.builtins.basestring
, which unfortunately is not compatible with py3.2. Due to the lack of unicode string marker support in py>=3.0,<3.3, it seems practically impossible to maintain support for these versions while allowing custom regex flags.