Runcommand Plugin: make the runcommand plugin more secure by default #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyholmes
force-pushed
the
lockdown-runcommand
branch
2 times, most recently
from
0d62bd7
to
5462594
Compare
Drop the `--talk=org.freedesktop.Flatpak` permission and default to executing commands with `flatpak-spawn` when available. Flatpak users will have to manually poke a hole in the sandbox to execute commands on the host and all users will have to disable the `isolate-subprocesses` setting, which comes with a warning. This is more inconvenient for the common use-case of the plugin, which typically involves running commands on the host, but it prevents user plugins from arbitrarily executing commands on the host for flatpak users.
andyholmes
added a commit
that referenced
this pull request
Oct 3, 2024
Unconfirmed, uninstrumented error:
```
WARNING: ThreadSanitizer: unlock of an unlocked mutex (or by a wrong thread) (pid=60215)
#0 pthread_mutex_unlock <null> (libtsan.so.2+0x5735c) (BuildId: c8455fafa477dccacaa74df59b23caba0427f5bf)
#1 tracker_triples_cursor_reset <null> (libtracker-sparql-3.0.so.0+0x7eb63) (BuildId: 8ba7590a425a128842dbc8ad9aabd1b97b930743)
Location is global '<null>' at 0x000000000000 (libsqlite3.so.0+0x15d208)
Mutex M0 (0x7f090a3d8208) created at:
#0 pthread_mutex_unlock <null> (libtsan.so.2+0x5735c) (BuildId: c8455fafa477dccacaa74df59b23caba0427f5bf)
#1 tracker_triples_cursor_reset <null> (libtracker-sparql-3.0.so.0+0x7eb63) (BuildId: 8ba7590a425a128842dbc8ad9aabd1b97b930743)
SUMMARY: ThreadSanitizer: unlock of an unlocked mutex (or by a wrong thread) (/lib64/libtsan.so.2+0x5735c) (BuildId: c8455fafa477dccacaa74df59b23caba0427f5bf) in pthread_mutex_unlock
```
andyholmes
added a commit
that referenced
this pull request
Oct 3, 2024
Unconfirmed, uninstrumented error:
```
WARNING: ThreadSanitizer: unlock of an unlocked mutex (or by a wrong thread) (pid=60215)
#0 pthread_mutex_unlock <null> (libtsan.so.2+0x5735c) (BuildId: c8455fafa477dccacaa74df59b23caba0427f5bf)
#1 tracker_triples_cursor_reset <null> (libtracker-sparql-3.0.so.0+0x7eb63) (BuildId: 8ba7590a425a128842dbc8ad9aabd1b97b930743)
Location is global '<null>' at 0x000000000000 (libsqlite3.so.0+0x15d208)
Mutex M0 (0x7f090a3d8208) created at:
#0 pthread_mutex_unlock <null> (libtsan.so.2+0x5735c) (BuildId: c8455fafa477dccacaa74df59b23caba0427f5bf)
#1 tracker_triples_cursor_reset <null> (libtracker-sparql-3.0.so.0+0x7eb63) (BuildId: 8ba7590a425a128842dbc8ad9aabd1b97b930743)
SUMMARY: ThreadSanitizer: unlock of an unlocked mutex (or by a wrong thread) (/lib64/libtsan.so.2+0x5735c) (BuildId: c8455fafa477dccacaa74df59b23caba0427f5bf) in pthread_mutex_unlock
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the
--talk=org.freedesktop.Flatpakpermission and default toexecuting commands with
flatpak-spawnwhen available.Flatpak users will have to manually poke a hole in the sandbox to
execute commands on the host and all users will have to disable the
isolate-subprocessessetting, which comes with a warning.This is more inconvenient for the common use-case of the plugin, which
typically involves running commands on the host, but it prevents user
plugins from arbitrarily executing commands on the host for flatpak
users.