wip/andyholmes/staging #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a simple base class with helpers for working in threads
andyholmes
force-pushed
the
wip/andyholmes/staging
branch
from
4aaa07f
to
6797d64
Compare
These fixes will have to be followed with some proper refacatoring, but at least put the project in a position to move forward without fear of heisenbugs and drastic hair-loss. * ValentChannel: extirpate ValentTaskQueue ValentTaskQueue was ultimately a bad idea that turned into a thread safety nightmare. Remove it and replace it's requirements with the locking provided by ValentObject. * ValentChannelService: use locking from ValentObject to fix races Derive from ValentObject and use its provided locking to appease ThreadSanitizer, albeit in some questionable ways.
* test-utils * add missing doc comment * assert valent_test_load_json() succeeds * test-plugin-fixture * avoid a needless function wrapper * close and assert-finalize channels * test-device * use channel helpers from test utils * add some helpers and check packets more thoroughly * ensure we're popping all packets off the endpoint * ensure endpoint is closed and finalized * test-mousepad-plugin * ensure we're popping all packets off the endpoint * add missing `isAck` to echo packet * test-telephony-plugin * ensure we're popping all packets off the endpoint * add missing fuzz tests
andyholmes
force-pushed
the
wip/andyholmes/staging
branch
from
6797d64
to
e709e8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.