wip/andyholmes/staging #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix two body definitions, in `kdeconnect.findmyphone.request` and `kdeconnect.lock.request`, mislabeled as `default` instead of `properties`.
* return proper fallback icons for all voice events * use per-called notification ID's, disregarding the event type to ensure older event notifications are replaced
* Use a GWeakRef when deferring device loading to the main thread If the manager wants to dispose while loading devices we don't want to bother constructing devices, so don't hold a reference to the manager. * Refactor valent_manager_ensure_device() to take an identity packet A device is never constructed in the absence of an identity packet, so require on to passed to the method.
Refactor `valent_device_new()` to take a `JsonNode` identity and add `valent_device_new_full()` which can take an additional `ValentData` object. This means `ValentManager` no longer needs to call the private method `valent_device_handle_packet()` and in standard usage the device ID is guaranteed to match the initial identity packet. As a bonus, `valent_device_handle_packet()` no longer has to check for incoming identity packets.
andyholmes
force-pushed
the
wip/andyholmes/staging
branch
from
dc943e1
to
e601046
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.