-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test and build in separate jobs #351
Conversation
b165ca3
to
b7d9624
Compare
23efc8b
to
236b759
Compare
236b759
to
d2e21b0
Compare
d2e21b0
to
53e4a40
Compare
5cf355e
to
5406571
Compare
5406571
to
4f45fbf
Compare
4f45fbf
to
f1a7c9b
Compare
This is ready now |
Cool, great idea! I'm just wondering why the |
Thanks! I separated the runtime tests from dev time tests. Dev time tests (such as bundling with Webpack and Rollup) are tested on the latest Node, and all the other tests are tested on old Node. This allows us to use the latest tools while keeping backward compatibility for old runtimes. |
Sounds reasonable. My only issue is that the npm script names failed to convey their purpose to me… How about Don't want to unnecessarily delay the merge, but since we cannot add comments to the package.json, we should pay a bit of extra attention to the naming there 🙂 |
Sure, that sounds good to me. |
This allows using the latest tools for building on the latest Node.js while supporting older versions for running the code
Fixes the errors in #349