Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storing friends #8

Closed
anestv opened this issue Jul 25, 2014 · 2 comments · Fixed by #34
Closed

Storing friends #8

anestv opened this issue Jul 25, 2014 · 2 comments · Fixed by #34
Assignees
@anestv
Labels
help wanted important question
Milestone
Profile page comp...

Comments

@anestv
Copy link
Owner

anestv commented Jul 25, 2014

As of now, friends work one-way, i.e. Alice can have Bob in her friends even if Bob does not.
This way users have more control over their privacy settings.

As of now, the friend list of a user is stored in JSON string format, in the DB table users. This make it easy to see if one can ask/view a user (at profile.php sent.php viewq.php) and change the whole list at once (at friends.php)

We could also store the friends in another table (user, friend). Then it would be easier to add/delete a friend and see if a particular user is a friends of another user (for example "Add Friend" button at profiles). Would this be better, and in what way?
anestv pushed a commit that referenced this issue Jul 25, 2014
Fixes #2 , Cleanup, Began #3
cec5ae2 
Removed old useless files, began working on Search (waiting to see if
the way friends are stored will change at #8 ), added style for error
messages in profile.php (You cannot ask/view) , removed backticks at SQL
queries
@anestv anestv added this to the Profile page complete milestone Aug 18, 2014
@anestv anestv mentioned this issue Sep 19, 2014
Closed
@anestv anestv mentioned this issue Oct 10, 2014
Closed
@anestv
Copy link
Owner Author

anestv commented Oct 11, 2014

We will go for the second choice, because of bug #24
Branch "friendships" will be created for the changes needed.

@anestv anestv self-assigned this Oct 12, 2014
@anestv
Copy link
Owner Author

anestv commented Oct 17, 2014

This query will be useful. We should include it in a fuction at autoPrepend.
https://gist.github.com/anestv/ab0d58585304e9766ab5

@anestv anestv mentioned this issue Oct 19, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anestv anestv

Labels
help wanted important question
Projects
None yet
Milestone
Profile page complete
Development

Successfully merging a pull request may close this issue.

Store friendships in another table anestv/pa
1 participant
@anestv