Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYSENG-1658: add e5e resources #142

Merged
1 commit merged into from
Mar 19, 2024
Merged

SYSENG-1658: add e5e resources #142

1 commit merged into from
Mar 19, 2024

Conversation

ghost
Copy link

@ghost ghost commented Nov 15, 2023 •
edited by ghost
Loading

Description

Checklist

  • added release notes to Unreleased section in CHANGELOG.md, if user facing change

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@ghost ghost self-assigned this Nov 15, 2023
@ghost ghost force-pushed the SYSENG-1658/add-e5e-resources branch 5 times, most recently from ffd8dae to b3636ba Compare November 15, 2023 10:53
@ghost
Copy link
Author

ghost commented Nov 15, 2023 •
edited by ghost
Loading

89Q12
89Q12 reviewed Nov 16, 2023
View reviewed changes
Copy link
Member

@89Q12 89Q12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add to the docs that one of the storage backends is mandatory.
Otherwise LGTM

@ghost ghost force-pushed the SYSENG-1658/add-e5e-resources branch from b3636ba to a2f623e Compare November 16, 2023 14:09
89Q12
89Q12 previously approved these changes Nov 16, 2023
View reviewed changes
@ghost ghost force-pushed the SYSENG-1658/add-e5e-resources branch from a2f623e to 9554b39 Compare November 17, 2023 09:46
89Q12
89Q12 previously approved these changes Nov 20, 2023
View reviewed changes
@ghost ghost force-pushed the SYSENG-1658/add-e5e-resources branch 4 times, most recently from 3ea3bd8 to 4f301d2 Compare March 12, 2024 12:33
@ghost ghost marked this pull request as ready for review March 12, 2024 12:41
@ghost ghost requested a review from 89Q12 March 12, 2024 12:41
89Q12
89Q12 previously approved these changes Mar 12, 2024
View reviewed changes
@ghost ghost force-pushed the SYSENG-1658/add-e5e-resources branch from 4f301d2 to d69324f Compare March 15, 2024 07:08
@ghost ghost force-pushed the SYSENG-1658/add-e5e-resources branch from d69324f to e9af021 Compare March 19, 2024 12:24
@ghost ghost merged commit 1eb8516 into main Mar 19, 2024
4 of 6 checks passed
@ghost ghost deleted the SYSENG-1658/add-e5e-resources branch March 19, 2024 12:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@89Q12