SIANXSVC-1203: Ensure library_version has correct value #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachtjasmin
force-pushed
the
feature/JO-SIANXSVC-1203-ensure-library_version-has-correct-value
branch
2 times, most recently
from
4af1ab2
to
080c7dc
Compare
beachmachine
force-pushed
the
feature/JO-SIANXSVC-1203-ensure-library_version-has-correct-value
branch
from
080c7dc
to
1e6df7f
Compare
beachmachine
requested changes
Jan 25, 2024
nachtjasmin
force-pushed
the
feature/JO-SIANXSVC-1203-ensure-library_version-has-correct-value
branch
3 times, most recently
from
6907b59
to
9be90dd
Compare
nachtjasmin
force-pushed
the
feature/JO-SIANXSVC-1203-ensure-library_version-has-correct-value
branch
from
9be90dd
to
a9a0baa
Compare
Several things had to get fixed in order for the library version to appear in the metadata. First and foremost, the GitHub Actions workflow was setting the PackageVersion (which is used for the NuGet package), but not the AssemblyVersion. This is now fixed by passing the tag via /p:Version. Second, the current retrieved version included the commit hash, which would have ended up to conflict with the database constraints of E5E which limit the version to 20 characters. In order to circumvent this problem, the hash is trimmed from the version. Because I had the time to work on this part of the code, I took the opportunity and made the E5ERuntimeMetadata sealed. Technically, this is a breaking change, however I don't expect that anyone is affected by it, so it's fine to put it in a patch release. Closes SIANXSVC-1203
beachmachine
force-pushed
the
feature/JO-SIANXSVC-1203-ensure-library_version-has-correct-value
branch
from
a9a0baa
to
dfbe794
Compare
beachmachine
deleted the
feature/JO-SIANXSVC-1203-ensure-library_version-has-correct-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several things had to get fixed in order for the library version to
appear in the metadata. First and foremost, the GitHub Actions workflow
was setting the
PackageVersion(which is used for the NuGet package),but not the
AssemblyVersion. This is now fixed by passing the tag via/p:Version.Second, the current retrieved version included the commit hash, which
would have ended up to conflict with the database constraints of E5E
which limit the version to 20 characters. In order to circumvent this
problem, the hash is trimmed from the version.
Because I had the time to work on this part of the code, I took the
opportunity and made the
E5ERuntimeMetadatasealed. Technically, this isa breaking change, however I don't expect that anyone is affected by it,
so for me it'd be fine to put it in a patch release.