Add example to reproduce race condition bug #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 74 74
Branches 14 18 +4
=====================================
Hits 74 74Continue to review full report at Codecov.
|
jpangelle
force-pushed
the
race-condition-bug
branch
from
0c0ee7f
to
12e91d3
Compare
zxqx
reviewed
Oct 13, 2019
|
|
||
| setTimeout(() => { | ||
| setDelay(1000); | ||
| setThing(colors.FUCHSIA); |
There was a problem hiding this comment.
setTimeout should always be wrapped by a useEffect - what are you trying to do here?
There was a problem hiding this comment.
Removed setTimeout and wrapped the state changes in a useEffect
zxqx
approved these changes
Oct 13, 2019
jpangelle
added a commit
that referenced
this pull request
Nov 22, 2019
* add example to reproduce race condition bug * remove setTimeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just to add an example to reproduce the race condition bug documented in issue #84