No enrichment randomized and testing patch #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng with random seed for no enrich and removal of duplicate tests
|
smh this one's gonna take me a while to get through |
ngreenwald
approved these changes
Aug 14, 2020
alex-l-kong
added a commit
that referenced
this pull request
Jan 14, 2021
* New and improved (like 2-4 lines changed haha) spatial analysis testing with random seed for no enrich and removal of duplicate tests * Just had to add that comment about 42 to botch PEP8... * Hopefully changing the random seed works (goodbye 42...) Co-authored-by: Noah Greenwald <noahfgreenwald@gmail.com>
y2kbugger
pushed a commit
that referenced
this pull request
Jul 29, 2021
* New and improved (like 2-4 lines changed haha) spatial analysis testing with random seed for no enrich and removal of duplicate tests * Just had to add that comment about 42 to botch PEP8... * Hopefully changing the random seed works (goodbye 42...) Co-authored-by: Noah Greenwald <noahfgreenwald@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The no enrichment cases for channel and cluster enrichment currently rely on a completely random generation of an array, which can cause the p-values and especially the z-scores to fail. For now, adding a random seed for that test will do the trick.
Duplicate tests for no enrichment also appeared, so we'll need to update those to test for p_neg (which was missing).
I still think it would be useful to implement a smarter way to randomly generate no_enrich tests in the near future without having to set a random seed, but for now, this should do the trick.