Extraction bugfix #177
Merged
Extraction bugfix #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-l-kong
pushed a commit
that referenced
this pull request
Jan 14, 2021
* test driven development * fixed indexing error
y2kbugger
pushed a commit
that referenced
this pull request
Jul 29, 2021
* test driven development * fixed indexing error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #175. The wrong index was being passed for the nuclear compartment. Because our test data was essentially identical between nuclear IDs and cell_ids, this wasn't caught. I fixed the indexing issue, and modified the test data so that it is passed different values for cell and nuclear labels, which can then be compared to make sure the assignment was done correctly.