Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _rtd folder for documentation to explain MIBI/ARK in more detail #221

Merged
merged 8 commits into from
Sep 15, 2020

Conversation

alex-l-kong
Copy link
Contributor

What is the purpose of this PR?

Addresses and closes #213. Currently, our ReadTheDocs page only supports a basic landing page and documentation. We want to have some more information to guide our users through how the actual pipeline works, how to set up their virtual environment, etc. We also want to make our ReadTheDocs site more sophisticated.

How did you implement your changes

We create a separate _rtd folder which will contain .md files we can link to in index.rst (specifically the toctree) which each explain a certain aspect of our work. We will also be updating our index.rst file to integrate these new files into the table of contents (aka the toctree).

Remaining issues

I have a set of template .md pages attached, but we may need to add/delete some of them. Please note that this PR only addresses the structure for our documentation moving forward. We will have another PR (or PRs) which will handle adding the meat to these .md files.

@alex-l-kong alex-l-kong self-assigned this Sep 15, 2020
@alex-l-kong
Copy link
Contributor Author

I still need to figure out how to get the Home page automatically selected in Sphinx, but I'm sure it's pretty easy to do. For now, would appreciate comments on the directory structure as well as how everything appears on ReadTheDocs (click "Details" next to the readthedocs badge to view).

For the record, Noah's contributing.md parses very nicely. When we actually start adding contents to these files, it would be good to follow the style he used for that .md file.

@ngreenwald
Copy link
Member

This looks great! It auto-generated sections based on the .md file headings. I notice that there's a hyperlink option for the sub-headings: is the best way to link from different docs to one another to embed the hardcoded absolute path to that heading, or is there some way we should use relative links or something within the docs? I remember you mentioning this before at one point

Copy link
Contributor

@ackagel ackagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great so far! I don't mind adding some stuff to the virtualenv file once this is merged in, with info on how to set up development within a docker container in VSCode

Copy link

@saeedseyyedi saeedseyyedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

@alex-l-kong
Copy link
Contributor Author

This looks great! It auto-generated sections based on the .md file headings. I notice that there's a hyperlink option for the sub-headings: is the best way to link from different docs to one another to embed the hardcoded absolute path to that heading, or is there some way we should use relative links or something within the docs? I remember you mentioning this before at one point

I think for now, it's OK to use the absolute path. It looks like DeepCell uses the same thing. If by any chance you're talking about how index.rst's toctrees are formatted (Tab <path_to_md_file>), then that's because this is the .rst way to alias your file to a better-looking name.

Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay great, we can use the full url links in that case

@ngreenwald ngreenwald merged commit 15e9f76 into master Sep 15, 2020
@ngreenwald ngreenwald deleted the doc_org_redux branch September 15, 2020 16:56
alex-l-kong added a commit that referenced this pull request Jan 14, 2021
…221)

* Push new documentation changes

* Fix toctree error and duplicate link in contributing.md

* Condense all sphinx parameters under the same heading, and remove extraneous comment from conf.py

* Link homepage to toctree

* Modify conf.py so it doesn't complain about lack of _rtd/landing.py in toctree

* Further standardize the homepage and landing page

* Change markdown tab to utils

* Remove extraneous commented test in data_utils_test.py
y2kbugger pushed a commit that referenced this pull request Jul 29, 2021
…221)

* Push new documentation changes

* Fix toctree error and duplicate link in contributing.md

* Condense all sphinx parameters under the same heading, and remove extraneous comment from conf.py

* Link homepage to toctree

* Modify conf.py so it doesn't complain about lack of _rtd/landing.py in toctree

* Further standardize the homepage and landing page

* Change markdown tab to utils

* Remove extraneous commented test in data_utils_test.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create layout for documentation files
4 participants