Refactor synthetic_spatial_datagen #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… signal_extraction modules
ngreenwald
requested changes
Sep 25, 2020
| @@ -31,7 +30,7 @@ def center_weighting_extraction(cell_coords, image_data, centroid): | |||
| center. | |||
|
|
|||
| Improves upon default extraction by including a level of certainty/uncertainty. | |||
| Note: cell_coords and centroid are computed from regionprops prior to calling the function | |||
| cell_coords and centroid are computed from regionprops prior to calling the function | |||
There was a problem hiding this comment.
I think we can just delete this line completely
ngreenwald
approved these changes
Sep 25, 2020
alex-l-kong
added a commit
that referenced
this pull request
Jan 14, 2021
y2kbugger
pushed a commit
that referenced
this pull request
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
A mini PR to address and close #189.
How did you implement your changes
Dramatically reduce and shorten the comments and function names in
synthetic_spatial_datagen, and by extension,signal_extraction.