Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channel names list for reading back in tifs from deepcell_input_dir #312

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

alex-l-kong
Copy link
Contributor

What is the purpose of this PR?

Addresses and closes #304. Because we're reading in the summed nuclear and membrane channels, we need to make sure that the channel list we pass in actually corresponds to that (and not the original list of channels). This PR patches that up.

How did you implement your changes

We simply change xr_channel_names to nuclear_summed and membrane_summed.

@alex-l-kong alex-l-kong self-assigned this Oct 29, 2020
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@alex-l-kong alex-l-kong merged commit ed1a7df into master Oct 29, 2020
@alex-l-kong alex-l-kong deleted the chan_stand branch October 29, 2020 05:00
alex-l-kong added a commit that referenced this pull request Jan 14, 2021
y2kbugger pushed a commit that referenced this pull request Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to get mask overlaid file due to channel names conflict
2 participants