Add scale argument to create_deepcell_output and run_deepcell_task functions #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngreenwald
requested changes
Nov 5, 2020
There was a problem hiding this comment.
Looks good! Two things.
- Can you update the description of the PR to close your issue?
- Can you test this out with some data? We don't do any correctness checks for the kiosk-client, so maybe you could take a file and run it using rescale of 2.0 and 0.5 to make sure it modifies predictions appropriately
|
I tested this with the data in the example_dataset folder, setting the rescale to 2.0 and 0.5. Both looked reasonable: at 2.0, the predicted objects were much larger than at 1.0, and at 0.5 the objects were smaller. I can upload some screenshots if that is necessary. |
|
Awesome! |
alex-l-kong
pushed a commit
that referenced
this pull request
Jan 14, 2021
…nctions (#323) * added scale arg to create_deepcell_output and run_deepcell_task functions * added scale arg to deepcell_service_utils_test function * fixed style errors
y2kbugger
pushed a commit
that referenced
this pull request
Jul 29, 2021
…nctions (#323) * added scale arg to create_deepcell_output and run_deepcell_task functions * added scale arg to deepcell_service_utils_test function * fixed style errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Addresses and closes #322 . This change allows users to add a scale value as input to create_deepcell_output, which rescales the data before prediction.
How did you implement your changes
I added
scaleas an input argument to thecreate_deepcell_outputandrun_deepcell_taskfunctions in the util module. The default value is 1.0 for both functions. Finally, before the value is submitted to the server, it is converted from float to string, as required by the deepcell API. I figured that most users would intuitively provide the scale value as a float.