Throw error on nonexistent channel reads in mibitiffs #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngreenwald
requested changes
Feb 24, 2021
ark/utils/tiff_utils.py
Outdated
| # make sure all passed channels were found | ||
| if channels is not None: | ||
| channel_names = [return_channel[1] for return_channel in return_channels] | ||
| found_channels = [channel not in channel_names for channel in channels] |
There was a problem hiding this comment.
We can do verify_in_list for this right?
There was a problem hiding this comment.
totally. I do think it should be an IndexError instead of a ValueError in this case, so I'll wrap it in a try/except block and re-raise the error as an IndexError.
There was a problem hiding this comment.
Sounds good. Other option would be to add option to specify error type as an argument to verify_in_list. I'm cool with either
ngreenwald
requested changes
Feb 25, 2021
|
yep, it passes the original message as well, and also notes that the error was caused by that error; basically builds a little traceback. |
ngreenwald
approved these changes
Feb 25, 2021
y2kbugger
pushed a commit
that referenced
this pull request
Jul 29, 2021
* adds error message for attempts to read non-existant channels in mibitiffs * corrects style error * uses verify_in_list in mibitiff read util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds error message to
read_mibitiffif a non-existent channel is provided as input. This makes debugging typos/capitalizations in channel names easier to catch.