Modify validate_paths to work outside docker #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ackagel
reviewed
Mar 4, 2021
|
All the ones that I found |
y2kbugger
pushed a commit
that referenced
this pull request
Jul 29, 2021
* update validate_paths * fix whitespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
The current validate_paths function assumes that the user is within the docker and all paths are prefixed with /data. However, as we start to use these functions elsewhere and pip install the library, we don't want this assumption to necessarily be true.
How did you implement your changes
I've modified this function to give the option of dropping the /data prefix requirement, and updated all calls to validate_paths which are outside of a jupyter notebook to use this new logic.