-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed mibi directory #508
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple commented lines that can be removed.
It's not clear from the github overview, but you deleted the entire /mibi folder and /templates_qc folder, right, not just the files in them?
Correct. |
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes angelolab/toffy#20. It removes the
mibi
directory as it is now intoffy
.How did you implement your changes
A detailed description of what modifications you made to the codebase. Please include details on what functions you needed to change, how you changed them, and why. If you added new functions, give a description of what they do, as well as any specific design decisions
Removed
ark\mibi
and thetemplates_qc
folders along with their contents.Remaining issues
None.