Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed mibi directory #508

Merged
merged 8 commits into from
Feb 26, 2022
Merged

Removed mibi directory #508

merged 8 commits into from
Feb 26, 2022

Conversation

srivarra
Copy link
Contributor

@srivarra srivarra commented Feb 24, 2022

  • deleted the mibi folder
  • adjusted templates_qc notebooks

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Closes angelolab/toffy#20. It removes the mibi directory as it is now in toffy.

How did you implement your changes

A detailed description of what modifications you made to the codebase. Please include details on what functions you needed to change, how you changed them, and why. If you added new functions, give a description of what they do, as well as any specific design decisions

Removed ark\mibi and the templates_qc folders along with their contents.

Remaining issues

None.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple commented lines that can be removed.

It's not clear from the github overview, but you deleted the entire /mibi folder and /templates_qc folder, right, not just the files in them?

ark/utils/notebooks_test.py Outdated Show resolved Hide resolved
@srivarra
Copy link
Contributor Author

Correct.

@ngreenwald ngreenwald merged commit 3d28e53 into master Feb 26, 2022
@ngreenwald ngreenwald deleted the remove_mibi_dir branch February 26, 2022 03:04
@srivarra srivarra added the enhancement New feature or request label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mibi folder from ark
2 participants