Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to ignore hidden files and directories #510

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Added option to ignore hidden files and directories #510

merged 3 commits into from
Mar 2, 2022

Conversation

srivarra
Copy link
Contributor

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Closes #506. The purpose of this PR is to add an option for the user to ignore hidden directories in io_utils::list_folders and hidden files in io_utils::list_files.

How did you implement your changes

When ignore_hidden == True, the functions ignore all files and folders which start with a .. Defaults to True.

Remaining issues

None.

ngreenwald
ngreenwald requested changes Mar 1, 2022
View reviewed changes
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor comments only

ark/utils/io_utils_test.py Outdated Show resolved Hide resolved
ark/utils/io_utils_test.py Outdated Show resolved Hide resolved
ark/utils/io_utils_test.py Outdated Show resolved Hide resolved
@srivarra srivarra requested a review from ngreenwald March 1, 2022 20:31
alex-l-kong
alex-l-kong approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@alex-l-kong alex-l-kong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing else to add, looks good!

@ngreenwald ngreenwald merged commit 60f2460 into master Mar 2, 2022
@ngreenwald ngreenwald deleted the ignore_hidden_files branch March 2, 2022 19:51
@srivarra srivarra added the enhancement New feature or request label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-l-kong alex-l-kong alex-l-kong approved these changes

@ngreenwald ngreenwald ngreenwald approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to ignore hidden files with list_files / list_folders
3 participants
@srivarra @ngreenwald @alex-l-kong