Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch channel file path creation for pixel cluster overlay #514

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

alex-l-kong
Copy link
Contributor

What is the purpose of this PR?

The order of the file path creation for channel files contained in FOV folder subdirectories got swapped due to merging issues. The line:

chan_file = os.path.join(
    fovs[0], img_sub_folder, io_utils.list_files(os.path.join(tiff_dir, img_sub_folder, fovs[0]), substrs=['.tif', '.tiff'])[0]
)

should be

chan_file = os.path.join(
    fovs[0], img_sub_folder, io_utils.list_files(os.path.join(tiff_dir, fovs[0], img_sub_folder, substrs=['.tif', '.tiff'])[0]
)

How did you implement your changes

See above

@alex-l-kong alex-l-kong self-assigned this Mar 24, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ngreenwald ngreenwald merged commit 4fcd44c into master Mar 24, 2022
@ngreenwald ngreenwald deleted the pixel_path_fix branch March 24, 2022 23:34
@srivarra srivarra added the bug Something isn't working label Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants