Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous output printed by ConsensusClusterPlus #545

Merged
merged 2 commits into from
May 17, 2022

Conversation

alex-l-kong
Copy link
Contributor

What is the purpose of this PR?

Closes #524. The call to ConsensusClusterPlus currently prints out a lot of logging output that's confusing and takes up a lot of space. We don't need to display this to the user and should suppress it.

How did you implement your changes

These outputs are generated using the message function. To fix this, enclose each line containing ConsensusClusterPlus with the suppressMessages function to remove them from the printout.

This change is included in both pixel_consensus_cluster.R and cell_consensus_cluster.R.

@alex-l-kong alex-l-kong self-assigned this May 13, 2022
@alex-l-kong alex-l-kong changed the title Remove extraneous output printed by `ConsensusClusterPlus Remove extraneous output printed by ConsensusClusterPlus May 13, 2022
@alex-l-kong alex-l-kong requested a review from cliu72 May 13, 2022 20:56
Copy link
Contributor

@cliu72 cliu72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@alex-l-kong alex-l-kong merged commit 521cf45 into master May 17, 2022
@alex-l-kong alex-l-kong deleted the consensus_clear branch May 17, 2022 17:25
@srivarra srivarra added the enhancement New feature or request label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify progress text during metaclustering
3 participants