remove_file_extensions
is more robust to various fov naming schemes
#577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #537.
Allows more complex fov name parsing in
remove_file_extensions
.Removes the extensions correctly for files named such as:
How did you implement your changes
Added explicit checks for the following file extensions:
"tiff", "tif", "png", "jpg", "jpeg", "tar", "gz", "csv", "feather"
.Added an extra test for more complicated fov filenames.
Remaining issues
Should we account for more file extensions?