-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove intermediate _clustered
/_consensus
directories/files from pixel and cell clustering pipeline
#586
Conversation
… clustering and one home file for cell clustering
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…ark-analysis into condence_cluster_data
This branch is almost done, need to verify the outputs match up compared to the original. |
…to condence_cluster_data
…ark-analysis into condence_cluster_data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Did you already run both notebooks on the HIV dataset to check that everything is working?
@ngreenwald yes, I'm currently running one more test to be sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one leftover path change in the notebook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some merge conflicts from the normalization PR I just put in
@ngreenwald resolved |
What is the purpose of this PR?
Closes #571. There is no need to create a separate
pixel_mat_clustered
directory/cell_mat_clustered
file as the data is just the channel expression/pixel cluster count expression values with an additionalpixel_som_cluster
/cell_som_cluster
attached. Ditto for thepixel_mat_consensus
directory/cell_mat_consensus
file. These should be removed from the pixel and cell clustering processes.How did you implement your changes
We should overwrite the original data with the newly created data in the
cluster_pixels
/pixel_consensus_cluster
(and similarly for the cell clustering functions).Remaining issues
There are a few extra checks we need to include for validation if the user decides to rerun the clustering pipeline in the same session.