PKG_FOLDER variable in setup.py cannot find requirements.txt due to filepath issue.
#624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srivarra
changed the title
setup.py, changed PKG_FOLDER variablesetup.py cannot find requirements.txt due to filepath issue.
ngreenwald
requested changes
Jun 29, 2022
|
toffy with ark on 3.7 installs properly on Drago. |
ngreenwald
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
ark-analysiswill not install properly via PyPI, the issue seems to reside with thePKG_FOLDERvariable.How did you implement your changes
Set
PKG_FOLDERthe same as it is intoffy.Remaining issues
Need to adjust ark-analysis requirement in angelolab/toffy#132, and make sure it can install properly.