Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the compression method of R feather saving 'uncompressed' #625

Closed
wants to merge 1 commit into from

Conversation

alex-l-kong
Copy link
Contributor

What is the purpose of this PR?

There have been issues with consistency in saving the .feather files in Python vs R. To prevent interoperability issues, we change the compression argument passed into write_feather in R to 'uncompressed'

@ngreenwald
Copy link
Member

It wasn't the compression. Getting around the same number of errors, now with a different error message.
image. Given that I used the MIBIAN a fair amount beforehand without running into these errors, it seems likely that its either the multiprocessing update or the switch to 3.7 that is causing these issues

@alex-l-kong
Copy link
Contributor Author

@ngreenwald weird, I'll have to look into this some more. I wonder if it's an OS-related issue with MIBIAN since neither myself nor Candace has run into this issue locally. Just to clarify, on MIBIAN, have you tried this process on other datasets and found the same or similar errors pop up?

@ngreenwald
Copy link
Member

This never popped up on my test dataset. I'm going to rerun clustering there to confirm that the issue comes up now. If so, it means it was one of the recent changes. Can you work with @srivarra to get a python 3.6 image (tagged with something besides latest) pushed to dockerhub so that I can rollback and see if that resolves it?

@srivarra srivarra self-assigned this Jun 29, 2022
@srivarra srivarra added the bug Something isn't working label Jun 29, 2022
@alex-l-kong
Copy link
Contributor Author

@ngreenwald I'm going to spend some time on the MIBIAN this afternoon to test it out on Candace's dataset and compare with the old and new Docker images when they both are posted. Will let you know if anything comes up.

This was referenced Jun 30, 2022
@ngreenwald
Copy link
Member

This was resolved in a previous PR

@ngreenwald ngreenwald closed this Aug 26, 2022
@ngreenwald ngreenwald deleted the som_compress branch August 26, 2022 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants