Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .json and .bin file compatibility to remove_file_extensions() #632

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

camisowers
Copy link
Contributor

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Closes #631

@camisowers camisowers self-assigned this Jul 7, 2022
@ngreenwald ngreenwald merged commit da89052 into master Jul 7, 2022
@ngreenwald ngreenwald deleted the remove_file_extension_fix branch July 7, 2022 23:43
@srivarra srivarra added the bug Something isn't working label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove_file_extensions not compatible with .bin or .json
3 participants