Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mantis Project - Improved Filtering of user Supplied FOVs #667

Merged
merged 6 commits into from
Aug 24, 2022

Conversation

srivarra
Copy link
Contributor

  • investigating mask issue
  • added fov mask filtering

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Closes #655.

How did you implement your changes

Updated the test to save different masks and segmentation labels for each FOV. In addition added filtering for user supplied FOVs, so only those masks with a supplied FOV get copied over. Improved the organization and documentation for this test function.

Remaining issues

Might want to refactor it one day, incase we create more Mantis related functions.

@srivarra srivarra added the bug Something isn't working label Aug 24, 2022
@srivarra srivarra self-assigned this Aug 24, 2022
@srivarra srivarra marked this pull request as ready for review August 24, 2022 22:51
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@ngreenwald ngreenwald merged commit 0d2270f into main Aug 24, 2022
@ngreenwald ngreenwald deleted the mantis_assign_cells branch August 24, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_mantis_project doesn't assign cells correctly
2 participants