-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove batching functionality from cell and pixel mask generation #727
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Which other functions use save_fov_images and label_cells_by_cluster? Are we going to end up removing the batching functionality from them in the future? Or is it really worth keeping them as is? |
@ngreenwald I thought about looping over each FOV in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay agreed, that should be a separate PR. As you find stuff like that, go ahead and add it to the overall design doc so we can keep track of what else needs to be changed.
What is the purpose of this PR?
Addresses part 2 of #718.
How did you implement your changes
Change the iteration in
generate_and_save_{pixel/cell}_cluster_masks
to a per-FOV basis, which requires deprecating thebatch_size
parameter.generate_{pixel/cell}_cluster_mask
will also support just a singlefov
string identifying which FOV to process (as opposed to a batch of FOVs).Because
save_fov_images
andlabel_cells_by_cluster
are used elsewhere in the repo, it's best to continue requiring afovs
list for these, and instead pass in a list with a single FOV fromgenerate_{pixel/cell}_cluster_mask
.