Standardize usage of .tiff extension
#801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
alex-l-kong
commented
Nov 1, 2022
alex-l-kong
commented
Nov 1, 2022
ngreenwald
requested changes
Nov 1, 2022
ngreenwald
requested changes
Nov 2, 2022
There was a problem hiding this comment.
All of those images in /example_dataset are no longer needed because of the huggingface dataset, right? If so they can be removed.
Some of that example data is for the spatial analysis notebooks (I think), so it needs to be kept around until we update the example dataset for those notebooks. However, anything that is only used for notebooks 1-4 can be deleted.
ngreenwald
requested changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Closes #792. Replace any use of
.tifwith.tiff.How did you implement your changes
Fairly straightforward renaming. A couple of caveats:
.tifin the.zipfiles, so these need to be explicitly renamed prior to save