Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Release v0.5.1 #889

Merged
merged 6 commits into from
Jan 26, 2023
Merged

Next Release v0.5.1 #889

merged 6 commits into from
Jan 26, 2023

Conversation

srivarra
Copy link
Contributor

@srivarra srivarra commented Jan 23, 2023

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Makes adjustments for the latest release.

In addition: Closes #886. Closes #888.

How did you implement your changes

Adjusted the requirements files, and made changes w.r.t newer versions of seaborn. In addition, percent_var_exp is deprecated as it isn't in use currently. Made adjustments for KMeans in scikit-learn as n_init needs to be specified to either a value or to "auto". Set it to "auto".

Remaining issues

@srivarra srivarra added the dependencies Pull requests that update a dependency file label Jan 23, 2023
@srivarra srivarra self-assigned this Jan 23, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ngreenwald
Copy link
Member

In addition, will you migrate the stuff that's currently in the developer docs section to the computational team wiki, and make a separate section for each repo?

i.e. for TMI, update the release tag in pyproject; for mibi-bin-tools, just make a new release, etc etc.

As we start having different requirements for what needs to be changed for each repo, it'll be helpful to have it one place to make sure we don't miss anything,.

@srivarra
Copy link
Contributor Author

@ngreenwald Good to create and push the tag for a new release?

@ngreenwald ngreenwald marked this pull request as ready for review January 24, 2023 20:17
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good

@srivarra srivarra merged commit e6050fc into main Jan 26, 2023
@srivarra srivarra deleted the next_release_v0.5.1 branch January 26, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

percent_var_exp is not calculated in spLDA.processing.compute_topic_eda() Loosen the Requirements
2 participants