Ensure z-score slider adjusts colorbar range when changed #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Closes #898. The z-score slider needs to be able to adjust the colorbar on change.
How did you implement your changes
Re-add the
calibratefunction and call it onself.normalizerwhenupdate_guiinvoked. Adjust range ofnormalizerback to(-1, 0, 1).Remaining issues
The normalizer still fails to add fractional ticks correctly (anything with .5 added to it). Additionally, for high z-score values, the tick range may not match exactly and the end ticks get drawn at weird spots.