Skip spatial LDA visualization tests due to Numpy error #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-l-kong
changed the title
analysis.test_visualize_fov_graphs test due to Numpy error
ngreenwald
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
The spatial LDA visualization tests currently imports
spatial_lda.visualizationandspatial_lda.processing. There's a bug at https://github.com/calico/spatial_lda/blob/primary/spatial_lda/online_lda.py#L31 where an incompatiblenp.floatcall is made. This is outdated with the most up-to-date version ofnumpyand throws an error on import.How did you implement your changes
We'll have to check in with
calicoto get this resolved, but in the meantime, pin numpy back at 1.23, the last version that doesn't throw an error.Remaining issues
Not sure how long
calicowill take to respond. They don't seem particularly invested. Who was Brian's point of contact on this?