Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "org.eclipse.angularjs.core.angularsource" content type #84

Closed
angelozerr opened this issue Aug 22, 2014 · 0 comments
Closed

Remove "org.eclipse.angularjs.core.angularsource" content type #84

angelozerr opened this issue Aug 22, 2014 · 0 comments
Assignees
Milestone

Comments

@angelozerr
Copy link
Owner

The content type "org.eclipse.angularjs.core.angularsource" is used to use a custom JFLex parser to create angular expression region. It work's great but there are some limitations :

  • the JFlex parser was redefined only for HTML and not for JSP. So for JSP highlight cannot be done.
  • HTML file must be opened with the specific AngularJS Editor which use LineStyleProviderForAngular to highlight angular expression. If you open the HTML file with WTP "HTML Editor", angular expression are not highlighted.

The highlighting can be done with semantic highlighting. It was done for JSP #80 So no need to build a custom DOM for Angular to detect region. Completions, Hover, Hyperlink for angular expression works too for JSP, so it will work too for HTML.

With semantic highlighting, we will able to support interpolation markeup #68

@angelozerr angelozerr added this to the 0.5.0 milestone Aug 22, 2014
@angelozerr angelozerr self-assigned this Aug 22, 2014
angelozerr added a commit that referenced this issue Aug 22, 2014
deprecated for custom DOMDocumentForAngular. See
#84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant