Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a more descriptive parent module artifactId #13

Closed
ppalaga opened this issue Oct 2, 2017 · 1 comment
Closed

Use a more descriptive parent module artifactId #13

ppalaga opened this issue Oct 2, 2017 · 1 comment

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Oct 2, 2017

This is for practical reasons: When importing the source tree as Maven projects, m2e takes (by default) the project names from <artifactId>. I had to search in my workspace for quite long to figure out that the source tree got imported under a nondescriptive root module parent. Knowing that I am importing ec4e, I'd expect it to appear under a name that contains ec4e. org.eclipse.ec4e.parent or simply ec4e-parent would be good names for the parent module, IMO. I'll send a PR in short.
@angelozerr
Copy link
Owner

Yes sure!

I'll send a PR in short.

Thanks!

angelozerr added a commit that referenced this issue Oct 2, 2017
@angelozerr
Merge pull request #14 from ppalaga/i13
b60d60b 
Fix #13 Use a more descriptive parent module artifactId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ppalaga @angelozerr