Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop JUnit for node.js tern server #2

Closed
angelozerr opened this issue Dec 20, 2013 · 4 comments
Closed

Develop JUnit for node.js tern server #2

angelozerr opened this issue Dec 20, 2013 · 4 comments

Comments

@angelozerr
Copy link
Owner

Develop JUnit for node.js tern server.

@pascalleclercq : initialize maven to do JUnit and JUnit must work with any OS (start the well node exe).
@angelozerr : develop JUnit for Develop JUnit for node.js tern server.

@angelozerr
Copy link
Owner Author

@pascalleclercq I have added a simple JUNit with Tern server and node.js at https://github.com/angelozerr/tern.java/blob/master/core/tern.core.tests/src/tern/core/tests/NodejsTernServerTest.java

As you can see I have hard coded the path of the node.exe for win32. The path should be dynamic (computed according the OS).

pascalleclercq added a commit that referenced this issue Dec 23, 2013
add tern.eclipse.ide.server.nodejs.embed.linux.gtk.x86_64 for cloudbees
@pascalleclercq
Copy link
Collaborator

Mostly done, see https://opensagres.ci.cloudbees.com/job/tern.java/

3 tests are in errors though:

  • tern.server.nodejs.process.NodejsProcessTest.badNodejsBaseDir
  • tern.server.nodejs.process.NodejsProcessTest.ok
  • tern.server.nodejs.process.NodejsProcessTest.badNodejsTernBaseDir

@pascalleclercq
Copy link
Collaborator

alternatively we can use this (easy) trick on cloudbees and assume node is always in $PATH of the build.

This would avoid tricky maintenance on node versions.

@angelozerr
Copy link
Owner Author

Good job Pascal! I have fixed problem with the 3 JUnits an build works now. I close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants