bake all bindist version strings into the nix file #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if one is missing, give an error saying what the value should be for all current ones, it is identical to the normal version, but it may differ for some releases, so the computation logic remains
cleverca22
added a commit
to input-output-hk/haskell.nix
that referenced
this pull request
Feb 27, 2020
manveru
approved these changes
Feb 27, 2020
cleverca22
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Feb 27, 2020
1 task
cleverca22
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Feb 27, 2020
angerman
approved these changes
Feb 27, 2020
angerman
pushed a commit
to input-output-hk/haskell.nix
that referenced
this pull request
Feb 27, 2020
* bump old-ghc-nix to use angerman/old-ghc-nix#6 * ensure that hydra caches the old-ghc-nix used at eval time
michaelpj
added a commit
to input-output-hk/haskell.nix
that referenced
this pull request
Mar 11, 2020
To pull in angerman/old-ghc-nix#6.
angerman
pushed a commit
to input-output-hk/haskell.nix
that referenced
this pull request
Mar 12, 2020
To pull in angerman/old-ghc-nix#6.
angerman
pushed a commit
that referenced
this pull request
May 12, 2021
if one is missing, give an error saying what the value should be for all current ones, it is identical to the normal version, but it may differ for some releases, so the computation logic remains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if one is missing, give an error saying what the value should be
for all current ones, it is identical to the normal version, but it may differ for some releases, so the computation logic remains
this entirely eliminates the issue that #5 was solving, by just eliminating IFD entirely from this stage