adambit追加 #7
Merged
adambit追加 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ありがとうございますっ |
nohtaray
reviewed
Oct 22, 2021
js/adambit.js
Outdated
| 'markets': { | ||
| 'BTC/ETH': { 'id': 'btc_eth', 'symbol': 'BTC/ETH', 'base': 'BTC', 'quote': 'ETH', 'baseId': 'btc', 'quoteId': 'eth' }, | ||
| 'BTC/USDT': { 'id': 'btc_usdt', 'symbol': 'BTC/USDT', 'base': 'BTC', 'quote': 'USDT', 'baseId': 'btc', 'quoteId': 'usdt' }, | ||
| 'BTC/XRP': { 'id': 'btc_xrp', 'symbol': 'BTC/XRP', 'base': 'BTC', 'quote': 'XRP', 'baseId': 'btc', 'quoteId': 'xrp' }, |
There was a problem hiding this comment.
全体的に「ETH 建で BTC を売買する」「XRP 建で BTC を売買する」のような設定になっているようです。
大多数の取引所は base と quote が逆の「BTC 建で ETH を売買する」ような形が多いですが、想定通りの設定になっていますか？
js/adambit.js
Outdated
| await this.loadMarkets (); | ||
| const market = this.market (symbol); | ||
| if (price === undefined) { | ||
| throw new InvalidOrder (this.id + ' createOrder() requires a price argument for both market and limit orders'); |
There was a problem hiding this comment.
成行注文をするために、price を指定しなくてもリクエストできるようにしていただきたいです。
|
ありがとうございます！ |
- fetchOpenOrders では取引履歴ではなく「未約定かつ未キャンセルの自分の注文」が取れること - IP制限解除 他
ayapi
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
先方からもらった差分をもとに桑村が代理でPRを出します。
参考スレッド
https://ango-ya.slack.com/archives/C0222A7LMEK/p1634784695000300?thread_ts=1634739179.464900&cid=C0222A7LMEK