-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including libraries #6
Comments
I'm preparing for rewrites and was wondering about the same... Not sure what is the best curse of actions here.... |
OK, so it turns out that some of my code examples already relay on 1.1.x features. I've commented out some tests for now but if we want to demonstrate some of 1.1.x features (http request interceptors, for example) we will need to do a big jump. BUT as of now it is all a bit of a mess... Some samples reference AngularJS from the CDN, some other from the lib folder. In both cases we've got hard-coded version number so bumping it is not fun. I was thinking of the best solution and I would say that we should keep AngularJS in the For now I'm would probably vote for putting it in the |
+1 ... sent from my tablet
|
Should we refer to specific local libraries, such as ../lib/angular/angular.js or refer to online version, such as http://code.angularjs.org/1.0.5/angular.js
The benefit of the first approach is that we can change what version we run off without having to go and change all the index.html files. The downside is that it makes it a bit of a pain if we have to distribute each chapter as a single zip file that will need to contain a copy of the libraries.
The text was updated successfully, but these errors were encountered: