Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schematics): dynamically install tslint-to-eslint-config as needed #425

Merged
merged 1 commit into from Apr 28, 2021

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented Apr 28, 2021

Refactors the internals of schematics to make a few improvements:

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #425 (ac48263) into master (da6bcf7) will decrease coverage by 1.51%.
The diff coverage is 63.33%.

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
- Coverage   65.65%   64.14%   -1.52%     
==========================================
  Files          14       14              
  Lines         591      594       +3     
  Branches      113      118       +5     
==========================================
- Hits          388      381       -7     
- Misses        153      162       +9     
- Partials       50       51       +1     
Impacted Files Coverage Δ
...nvert-tslint-to-eslint/convert-to-eslint-config.ts 50.00% <50.00%> (-6.25%) ⬇️
packages/schematics/src/utils.ts 70.40% <65.00%> (-2.78%) ⬇️
...s/schematics/src/convert-tslint-to-eslint/index.ts 46.55% <66.66%> (+0.35%) ⬆️
...matics/src/migrations/update-2-0-0/update-2-0-0.ts 96.77% <100.00%> (+4.66%) ⬆️
...matics/src/migrations/update-3-0-0/update-3-0-0.ts 90.00% <100.00%> (+3.63%) ⬆️

@nx-cloud
Copy link

nx-cloud bot commented Apr 28, 2021

Nx Cloud Report

CI ran the following commands for commit ac48263. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=check-configs --all --parallel
#000000 nx run-many --target=test --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@JamesHenry JamesHenry merged commit 27ca474 into master Apr 28, 2021
@JamesHenry JamesHenry deleted the dynamic-tslint-to-eslint-config-install branch April 28, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant