Skip to content

fix(template-parser): add missing Conditional and its keys to VisitorKeys #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2021

Conversation

rafaelss95
Copy link
Member

@rafaelss95 rafaelss95 commented May 13, 2021

When working on #444, I realized that this key was missing and it was a little difficult to make the rules work correctly without a lot of effort.

Relates to #280 (comment).

@rafaelss95 rafaelss95 requested a review from JamesHenry May 13, 2021 05:17
@rafaelss95 rafaelss95 changed the title fix(template-parser): add missing Conditional and its keys to VisitorKeys fix(template-parser): add missing Conditional and its keys to VisitorKeys May 13, 2021
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #445 (971ba62) into master (5f4e4a8) will decrease coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
- Coverage   66.05%   65.82%   -0.24%     
==========================================
  Files          15       14       -1     
  Lines         604      591      -13     
  Branches      120      118       -2     
==========================================
- Hits          399      389      -10     
+ Misses        152      150       -2     
+ Partials       53       52       -1     
Impacted Files Coverage Δ
packages/builder/src/utils/eslint-utils.ts

@nx-cloud
Copy link

nx-cloud bot commented May 13, 2021

Nx Cloud Report

CI ran the following commands for commit 971ba62. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=check-configs --all --parallel
#000000 nx run-many --target=test --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@JamesHenry JamesHenry merged commit 5ad0f1a into angular-eslint:master May 13, 2021
@rafaelss95 rafaelss95 deleted the feat/parser-conditional branch May 13, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants